Port #[instruction_set] to attribute parser#150193
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 31, 2025
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
requested changes
Dec 20, 2025
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Bryntet
force-pushed
the
parse_instruction_set
branch
4 times, most recently
from
2815243 to
25f9a74
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Bryntet
force-pushed
the
parse_instruction_set
branch
from
25f9a74 to
6fd2c64
Compare
Bryntet
force-pushed
the
parse_instruction_set
branch
from
6fd2c64 to
d42c32b
Compare
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Contributor
|
@bors r- |
bors
added
S-waiting-on-author
Bryntet
force-pushed
the
parse_instruction_set
branch
from
d42c32b to
0516456
Compare
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Bryntet
force-pushed
the
parse_instruction_set
branch
from
8df47f0 to
a355714
Compare
Contributor
|
@bors try jobs=arm-android |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 29, 2025
Port `#[instruction_set]` to attribute parser try-job: arm-android
This comment has been minimized.
This comment has been minimized.
Contributor
Bryntet
force-pushed
the
parse_instruction_set
branch
from
a355714 to
a95d41d
Compare
This comment has been minimized.
This comment has been minimized.
Bryntet
force-pushed
the
parse_instruction_set
branch
from
a95d41d to
acd6ba4
Compare
Contributor
|
@bors try jobs=arm-android |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 31, 2025
Port `#[instruction_set]` to attribute parser try-job: arm-android
Contributor
Contributor
|
@bors r+ rollup=iffy |
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Dec 31, 2025
Rollup merge of #150193 - Bryntet:parse_instruction_set, r=JonathanBrouwer Port `#[instruction_set]` to attribute parser Please note the test changes, and deprecation of `E0778` and `E0779` In my opinion, all errors related to this attribute are improved I think, except for if you have `#[instruction_set(arm::)]` in which case there's an `error: expected identifier, found <eof>`, which is quite unhelpful I think, but this seems to be a limitation of the general attribute parsing flow r? `@JonathanBrouwer`
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note the test changes, and deprecation of
E0778andE0779In my opinion, all errors related to this attribute are improved I think, except for if you have
#[instruction_set(arm::)]in which case there's anerror: expected identifier, found <eof>, which is quite unhelpful I think, but this seems to be a limitation of the general attribute parsing flowr? @JonathanBrouwer